Skip to content

espressif: fix esp32 console_write loop forever if cnt too large #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

espressif: fix esp32 console_write loop forever if cnt too large #2398

merged 1 commit into from
Oct 23, 2025

Conversation

@moculll
Copy link
Contributor

@moculll moculll commented Jul 22, 2025

spilt buffer to make sure console_write won't occupy forever

@moculll moculll requested a review from almir-okato as a code owner July 22, 2025 08:29
@de-nordic de-nordic added the area: espressif Affects the Espressif port label Jul 29, 2025
almir-okato
almir-okato reviewed Oct 22, 2025
View reviewed changes
Copy link
Collaborator

@almir-okato almir-okato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only 2 points, could you please sign your commit and also rebase it?

@moculll
Copy link
Contributor Author

moculll commented Oct 23, 2025

Looks good to me. Only 2 points, could you please sign your commit and also rebase it?

verified the commit and rebased it, thanks dude

@almir-okato
Copy link
Collaborator

Looks good to me. Only 2 points, could you please sign your commit and also rebase it?

verified the commit and rebased it, thanks dude

Thanks!
I see you've authenticated your commit, however the CI is still failing when it checks for "Signed off by" in the commit. That would be done by using git commit -s instead of using the capital -S argument.

@moculll
espressif: fix esp32 console_write loop forever if cnt too large
0894494 
spilt buffer to make sure console_write won't occupy forever

Signed-off-by: moculll <823309460@qq.com>
@moculll
Copy link
Contributor Author

moculll commented Oct 23, 2025

Looks good to me. Only 2 points, could you please sign your commit and also rebase it?

verified the commit and rebased it, thanks dude

Thanks! I see you've authenticated your commit, however the CI is still failing when it checks for "Signed off by" in the commit. That would be done by using git commit -s instead of using the capital -S argument.

Thanks dude, I've added the signed off mark to the commit

@almir-okato almir-okato merged commit 524b80b into mcu-tools:main Oct 23, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@almir-okato almir-okato almir-okato approved these changes

Assignees

@almir-okato almir-okato

Labels

area: espressif Affects the Espressif port

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moculll @almir-okato @de-nordic